Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Doc] Add guides for end-to-end encryption in Node.js client #10317

Merged
merged 3 commits into from
Apr 23, 2021

Conversation

Anonymitaet
Copy link
Member

@Anonymitaet Anonymitaet added the doc Your PR contains doc changes, no matter whether the changes are in markdown or code files. label Apr 22, 2021
@Anonymitaet Anonymitaet self-assigned this Apr 22, 2021
@Anonymitaet
Copy link
Member Author

@zymap @tuteng @Huanli-Meng @jennifer88huang could you please help review? Thanks

@@ -27,7 +27,7 @@ Compatibility between each version of the Node.js client and the C++ client is a
| 1.0.0 | 2.3.0 or later |
| 1.1.0 | 2.4.0 or later |
| 1.2.0 | 2.5.0 or later |
| 1.3.0 | 2.7.0 or later |
| 1.3.0 | 2.7.1 or later |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think 1.3.0 does not support this feature, we need to wait for the next release of the node client

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tuteng OK, then I've removed | 1.3.0 | 2.7.1 or later | for both master and 2.7.2. PTAL.

@eolivelli
Copy link
Contributor

I am removing 2.7.2 label,
does are built from master, correct ?
@Anonymitaet

@Anonymitaet
Copy link
Member Author

Anonymitaet commented Apr 29, 2021

@eolivelli I've added docs for both 2.7.2 and master, so users can read this content in 2.7.2 and master.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/client doc Your PR contains doc changes, no matter whether the changes are in markdown or code files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants